Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(env): early return causing nil env table error #91

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix(env): early return causing nil env table error #91

merged 1 commit into from
Aug 1, 2024

Conversation

caenrique
Copy link
Contributor

@caenrique caenrique commented Aug 1, 2024 •
edited
Loading

Early return inside this for loop is causing the assignment here to be nil when reading env variables from a .env file containing at least one empty line or a comment.

@caenrique caenrique requested a review from gorillamoe as a code owner August 1, 2024 11:18
@gorillamoe gorillamoe self-assigned this Aug 1, 2024
@gorillamoe gorillamoe added the bug Something isn't working label Aug 1, 2024
@gorillamoe gorillamoe merged commit d353427 into mistweaverco:main Aug 1, 2024
@gorillamoe
Copy link
Member

Thanks for your contribution <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorillamoe gorillamoe Awaiting requested review from gorillamoe gorillamoe is a code owner

Assignees

@gorillamoe gorillamoe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caenrique @gorillamoe