Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if automatic events flag is set before flushing #526

Merged
merged 11 commits into from
Mar 23, 2022

Conversation

jaredmixpanel
Copy link
Contributor

@jaredmixpanel jaredmixpanel commented Mar 9, 2022

In the event that the trackAutomaticEvents flag has not been set, either in the initializer or by a /decide response, we will not flush any automatic event and instead hold them in the queue until one of the flags is set and upon next flush, we will discard them if the flag is false or flush them if the flag is true.

@jaredmixpanel jaredmixpanel changed the title [WIP] Check if decide has been fetched before flushing [WIP] Check if automatic events flag is set before flushing Mar 15, 2022
@jaredmixpanel jaredmixpanel requested a review from zihejia March 16, 2022 00:40
@jaredmixpanel jaredmixpanel changed the title [WIP] Check if automatic events flag is set before flushing Check if automatic events flag is set before flushing Mar 17, 2022
Copy link
Contributor

@zihejia zihejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredmixpanel jaredmixpanel merged commit e49ec46 into master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants