Add Dev NPS Survey Log & semaphore.signal() in Decide #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zihejia
reviewed
Apr 14, 2022
Sources/Network.swift
Outdated
| class func trackIntegration(apiToken: String, serverURL: String, completion: @escaping (Bool) -> Void) { | ||
| let requestData = JSONHandler.encodeAPIData([["event": "Integration", | ||
| "properties": ["token": "85053bf24bba75239b16a601d9387e17", | ||
| class func trackEvent(eventName: String, apiToken: String, distinctId: String, completion: @escaping (Bool) -> Void) { |
There was a problem hiding this comment.
better rename it or put some comments to avoid people using it by mistake.
There was a problem hiding this comment.
might not be an issue for SPM but could be an issue if they include the source code.
zihejia
reviewed
Apr 14, 2022
Sources/Mixpanel.swift
Outdated
| '---------------------------------------------------------------------------------' | ||
| """) | ||
| UserDefaults.standard.set(surveyShownCount + 1, forKey: "MPSurveyShownCount") | ||
| Network.trackEvent(eventName: "Dev NPS Survey Logged", apiToken: "metrics-1", distinctId: distinctId) { (_) in } |
There was a problem hiding this comment.
would be nice to add the property surveyShownCount as well
jaredmixpanel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function that will occasionally log a link to our developer experience NPS survey
Adds an additional
semaphore.signal()in Decide as a possible fix for #532