Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails when Source Folder has Subfolders with Images #83

Closed
Rakhmanov opened this issue Mar 12, 2019 · 4 comments
Closed

Fails when Source Folder has Subfolders with Images #83

Rakhmanov opened this issue Mar 12, 2019 · 4 comments

Comments

@Rakhmanov
Copy link

In version 1.0.0,
Changes have broke our webpack configuration code with following error:
{ Error: EISDIR: illegal operation on a directory, read errno: -21, code: 'EISDIR', syscall: 'read' }.

What happened is now spiritesmith was trying reading content of the subfolder as if it was a file.
Folder was supplied to it as a valid path for a sprite, then it fatally crashed.

I'm working on getting it filtered out. And expecting to have pull request for it.

@Rakhmanov Rakhmanov changed the title Fails when Source Sprites Folder has Subfolders with Images Fails when Source Folder has Subfolders with Images Mar 12, 2019
@mixtur
Copy link
Owner

mixtur commented Mar 13, 2019

So before 1.0.0 it was fine? I can only imagine this happening if you have .png in your directory's name. Is that the case?

@Rakhmanov
Copy link
Author

Rakhmanov commented Mar 13, 2019 via email

@lobodol
Copy link

lobodol commented Apr 5, 2019

Hello,
I face the same issue.
As long as there is no sub-folder in my assets/ dir, the plugin works fine.
But as soon as I move some images in a sub-folder,I got the same error message.

Are you planing to fix this issue soon ?

@mixtur
Copy link
Owner

mixtur commented Apr 6, 2019

should be fixed in 1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants