-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails when Source Folder has Subfolders with Images #83
Comments
Rakhmanov
changed the title
Fails when Source Sprites Folder has Subfolders with Images
Fails when Source Folder has Subfolders with Images
Mar 12, 2019
So before 1.0.0 it was fine? I can only imagine this happening if you have .png in your directory's name. Is that the case? |
The name of the folder does not have png in its name naturally.
The reason is that list of pngs now is obtained through call to the method gaze.watched() which return folder names and files watched. Contrary to it's documentation. So it is easy to get confused.
To fix that, I have been able to make it work by filtering results that contain "/" as a last symbol. Which is consistent with method call results.
Where before version 1.0.0 it was done though glob query, which was getting files matched directly.
On Mar 12, 2019 10:20 PM, Michael Turkeev <notifications@github.com> wrote:
So before 1.0.0 it was fine? I can only imagine this happening if you have .png in your directory's name. Is that the case?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#83 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AChDKHyHYnN5c8u5cZf1Kh2l2vd0W2Wgks5vWIqxgaJpZM4brxcc>.
|
Closed
Hello, Are you planing to fix this issue soon ? |
should be fixed in 1.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In version 1.0.0,
Changes have broke our webpack configuration code with following error:
{ Error: EISDIR: illegal operation on a directory, read errno: -21, code: 'EISDIR', syscall: 'read' }
.What happened is now spiritesmith was trying reading content of the subfolder as if it was a file.
Folder was supplied to it as a valid path for a sprite, then it fatally crashed.
I'm working on getting it filtered out. And expecting to have pull request for it.
The text was updated successfully, but these errors were encountered: