Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Plugin): add missing binding to sprite cleanup function #48

Merged
merged 1 commit into from
Dec 14, 2017

Conversation

liorcode
Copy link
Contributor

When using multiple instances of the plugin, each instance will delete sprite created by the previous one.

This is due to a missing "this" binding for the cleanup callback. Without the binding, the "this" is the the same one for each iteration.

@liorcode liorcode mentioned this pull request Dec 14, 2017
@mixtur
Copy link
Owner

mixtur commented Dec 14, 2017

Ouch. I guess I am too used to use arrow functions.

@mixtur mixtur merged commit 5b71292 into mixtur:master Dec 14, 2017
@mixtur
Copy link
Owner

mixtur commented Dec 14, 2017

I'll publish it later today.

@liorcode
Copy link
Contributor Author

yeah, it is hard to use regular function these days :)
thanks!

@liorcode liorcode deleted the fix-sprite-cleanup branch November 1, 2018 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants