Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handlebarsHelpers #49

Merged
merged 1 commit into from
Jan 2, 2018
Merged

add handlebarsHelpers #49

merged 1 commit into from
Jan 2, 2018

Conversation

lcxfs1991
Copy link
Contributor

No description provided.

@lcxfs1991
Copy link
Contributor Author

FYI:
https://github.com/twolfson/gulp.spritesmith
Option: cssHandlebarsHelpers

@lcxfs1991
Copy link
Contributor Author

lcxfs1991 commented Dec 18, 2017

Hi @mixtur What do you think of this feature?

In addition, would you also nominate more people to become collaborators?

@lcxfs1991
Copy link
Contributor Author

hi what do you think of this feature?

@lcxfs1991
Copy link
Contributor Author

TAT @mixtur still busy?

@mixtur
Copy link
Owner

mixtur commented Jan 2, 2018

Sorry, I have pretty much no excuse to answer this late(
handlebarsHelpers seems like a good idea. Your code also seems fine. I'll test it locally for a bit and then probably will merge it.
About collaborators - yep why not. Especially given that I do not have much time myself and not actually using the plugin in my own projects. I am not sure how to pick the right people though.

@lcxfs1991
Copy link
Contributor Author

Thank you for answering. Hopefully you can open an issue or ask webpack community for help. Then you may recruit a suitable guy to operate this project together.

@mixtur mixtur merged commit 4107ec5 into mixtur:master Jan 2, 2018
@mixtur
Copy link
Owner

mixtur commented Jan 2, 2018

Published in 0.4.0 though note that in case of multiple instances of plugin, helpers will be shared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants