git bisect start # status: waiting for both good and bad commits # bad: [6333ec434907a3bfb00afc4bd35f2b929432dba2] Merge remote-tracking branch 'upstream/2.3' git bisect bad 6333ec434907a3bfb00afc4bd35f2b929432dba2 # status: waiting for good commit(s), bad commit known # good: [b4ef3e05cdf9496ba0f0e1215b10bd1379b26829] Merge pull request #2810 from xerus2000/trackset-capability git bisect good b4ef3e05cdf9496ba0f0e1215b10bd1379b26829 # skip: [b845529066733b30ef3827506b59846a305acaf1] Improve ControllerEngine error message on callbacks git bisect skip b845529066733b30ef3827506b59846a305acaf1 # skip: [191ce6f15612ce9ea5c3e155d37590dd672f41e0] use function pointers for Qt connections in ControllerEngine git bisect skip 191ce6f15612ce9ea5c3e155d37590dd672f41e0 # skip: [4047bf810b84bb382815583da2c16c3f769eb31b] Add QtQml dependency to travis config file git bisect skip 4047bf810b84bb382815583da2c16c3f769eb31b # skip: [bd2185a9572164718c02d3a1bf98119f71227cab] Avoid recalculation of m_byteArrayToScriptValueJSFunction git bisect skip bd2185a9572164718c02d3a1bf98119f71227cab # skip: [ed4b00c99f08595d48e8a4ba1b6825f8941bfd41] Xone K2: use Function.prototype.bind for QJSEngine git bisect skip ed4b00c99f08595d48e8a4ba1b6825f8941bfd41 # skip: [8bd4ad978d584c7b9ea107bdd6b4d0e0e97ccffe] Pioneer DDJ-SB2: use Function.prototype.bind for QJSEngine git bisect skip 8bd4ad978d584c7b9ea107bdd6b4d0e0e97ccffe # bad: [98bc0408deee3ca73a14b351cc815709493520e9] ControllerEngine: cleaup comments and code formatting git bisect bad 98bc0408deee3ca73a14b351cc815709493520e9 # skip: [99f9f36e7272eec433cd8fe0d6c91a69e9ec850a] Merge pull request #6 from Be-ing/qjsengine_migration git bisect skip 99f9f36e7272eec433cd8fe0d6c91a69e9ec850a # skip: [431c40a2adb3f4cbc7c00713ae454b9ef0f0a279] Fix merge and simplify tests git bisect skip 431c40a2adb3f4cbc7c00713ae454b9ef0f0a279 # skip: [fa6393b4599301b3dec3fe00aa41722ed4562d81] remove Lodash git bisect skip fa6393b4599301b3dec3fe00aa41722ed4562d81 # skip: [e622a077f3323cbed80337f3c9a3cab7113cbc13] Merge branch 'master' into migrate-to-QJSEngine git bisect skip e622a077f3323cbed80337f3c9a3cab7113cbc13 # skip: [619b1df8213049938c80097a2db3f0f6d640c6a8] Throw QJSEngine exceptions on evaluation failure of callbacks git bisect skip 619b1df8213049938c80097a2db3f0f6d640c6a8 # skip: [e5916c146f94c0832e3fabe453fccf104b0c81c0] Merge branch 'master' into migrate-to-QJSEngine git bisect skip e5916c146f94c0832e3fabe453fccf104b0c81c0 # skip: [e2441bdeb0f749a371a518cacdcf2cfa62d3fde2] Replace QtScript classes with QtQml script classes git bisect skip e2441bdeb0f749a371a518cacdcf2cfa62d3fde2 # skip: [72cd1ca61ce819bce54a60905c6d5df2133b66c8] fix script validation tests failing with nonexistent COs git bisect skip 72cd1ca61ce819bce54a60905c6d5df2133b66c8 # skip: [08dd11055981b2d31ea92aea7d19a2d7828fe0d3] Add checks for JS engine evaluation errors git bisect skip 08dd11055981b2d31ea92aea7d19a2d7828fe0d3 # skip: [9058f5fe4b35903a43a342c970e6913d8184b996] Mixtrack Platinum: use Function.prototype.bind for QJSEngine git bisect skip 9058f5fe4b35903a43a342c970e6913d8184b996 # bad: [4b297dd921ba144e32baddc70aecd27bd3e63c03] Roland DJ 505: use Function.prototype.bind for QJSEngine git bisect bad 4b297dd921ba144e32baddc70aecd27bd3e63c03 # skip: [a4c198b56e22a6369fefb21c7e80fe3204cb845c] Components.js: remove dependency on Lodash git bisect skip a4c198b56e22a6369fefb21c7e80fe3204cb845c # skip: [183eb086b7ebd0c8fe0fa41e61a1051205be40b1] Update comments git bisect skip 183eb086b7ebd0c8fe0fa41e61a1051205be40b1 # skip: [cfc41426326019c8afe868b3a1105ee1cbbacb88] Merge branch 'master' into migrate-to-QJSEngine git bisect skip cfc41426326019c8afe868b3a1105ee1cbbacb88 # skip: [8906c5d410f0040c45d7afb07d6b2f822057caa0] Correct message on ControllerEngine script error dialog git bisect skip 8906c5d410f0040c45d7afb07d6b2f822057caa0 # skip: [da214be64ae862bba06a75833bedefa71446e5d7] Rename ControllerEngine member git bisect skip da214be64ae862bba06a75833bedefa71446e5d7 # skip: [aa28540a64896a1d36e700b5a22b286d0cfe6516] Don't open new error dialogs when there's already one git bisect skip aa28540a64896a1d36e700b5a22b286d0cfe6516 # skip: [98818df3db8d9f02b612c3ac357e9ad1f89ec036] Rename function in ControllerEngine git bisect skip 98818df3db8d9f02b612c3ac357e9ad1f89ec036 # skip: [d3c5f654b7d809fe40f9d8300760e82211162d09] make ControllerEngine throw an errorr on faulty makeConnection callback git bisect skip d3c5f654b7d809fe40f9d8300760e82211162d09 # skip: [803d1cb7cdc92a4e4420ad3f56c5a78dedb87d69] Remove mixco based controlelr scripts git bisect skip 803d1cb7cdc92a4e4420ad3f56c5a78dedb87d69 # skip: [674033100be87f0a65ab70a2a6a75ea5be1beaad] make ControllerEngine throw an errorr on faulty makeConnection callback git bisect skip 674033100be87f0a65ab70a2a6a75ea5be1beaad # skip: [ab78036ad5364eb746f9a16eada978f4f40aa43a] Merge branch 'master' into migrate-to-QJSEngine git bisect skip ab78036ad5364eb746f9a16eada978f4f40aa43a # skip: [b57ef7bedee6b0376324eaccf49e010164bd5acd] Add missing function in header file git bisect skip b57ef7bedee6b0376324eaccf49e010164bd5acd # skip: [f2610e3e142f313ddb0ccc906ab763723fdc9d8a] Merge pull request #10 from dszakallas/upgrade-lp git bisect skip f2610e3e142f313ddb0ccc906ab763723fdc9d8a # skip: [49e01edf98ba7e8e9bbaf7a059ad59337bac1246] Fix controller scripts git bisect skip 49e01edf98ba7e8e9bbaf7a059ad59337bac1246 # skip: [bd58277c420841a90e667fd6539938ddba3178c6] Add missing Q_OBJECT macro git bisect skip bd58277c420841a90e667fd6539938ddba3178c6 # skip: [f2f04d2c599955e1618e143e13932462229b4849] Patch novation launchpad generated scripts git bisect skip f2f04d2c599955e1618e143e13932462229b4849 # skip: [60ac31499d8fdad7b6e3ab911607ae390becf671] Merge branch 'master' into migrate-to-QJSEngine git bisect skip 60ac31499d8fdad7b6e3ab911607ae390becf671 # skip: [90d67701542cc994ce31e7ecc9c7dc32595894eb] Add QtQml to linux appveyor config git bisect skip 90d67701542cc994ce31e7ecc9c7dc32595894eb # skip: [d5a980e3e956523af5d45a67ceb4f8762cac3911] Fix beginTimer trying to evaluate the result of an evaluation git bisect skip d5a980e3e956523af5d45a67ceb4f8762cac3911 # skip: [ecedd59ff81037221a09514a63de9c09e42b19be] remove 'use strict' from Novation Launchpad scripts git bisect skip ecedd59ff81037221a09514a63de9c09e42b19be # skip: [a7a7bdb7b53f38d428f01ad8915635c185d549b8] Add FakeControllerJSProxy git bisect skip a7a7bdb7b53f38d428f01ad8915635c185d549b8 # skip: [c2ebe262ef0d6548eabb4da64a9379183a10cb97] Merge remote-tracking branch 'upstream/master' into qjsengine_migration git bisect skip c2ebe262ef0d6548eabb4da64a9379183a10cb97 # skip: [ad2e8140535c48e52058f2e17a8171fd52a2f5e9] Fix typo in comment git bisect skip ad2e8140535c48e52058f2e17a8171fd52a2f5e9 # skip: [28497ba4c66ba2c5cb1b5416b3b212d5515114a1] remove controller scripts' dependency on Lodash git bisect skip 28497ba4c66ba2c5cb1b5416b3b212d5515114a1 # skip: [ca59d2dc91dbd127c2ba31a934a935bbf2d52253] Fix method hiding warning in FakeController git bisect skip ca59d2dc91dbd127c2ba31a934a935bbf2d52253 # bad: [3970b4e3e940bbf656e9770d67a26aa2c16151cc] Revert "controllers: allow scripts to work without XML mappings" git bisect bad 3970b4e3e940bbf656e9770d67a26aa2c16151cc # skip: [6ddae3d74dd019248c2dda90e61623fd804b7555] Remove unused evaluate slot in ControllerEngine git bisect skip 6ddae3d74dd019248c2dda90e61623fd804b7555 # skip: [059e6a32a0c064992009f856cc6bcddb95df939d] Merge branch 'master' into migrate-to-QJSEngine git bisect skip 059e6a32a0c064992009f856cc6bcddb95df939d # skip: [50f80590d0644089c31bb84b15cea23f59c8ff42] Add nullengine exception handling git bisect skip 50f80590d0644089c31bb84b15cea23f59c8ff42 # skip: [de53702328d45b0f96a486c414e5a60d376757c9] Add comment on ControllerEngine version git bisect skip de53702328d45b0f96a486c414e5a60d376757c9 # bad: [a99fd387c3b4d70740b3956bc9e21538eb0f62f6] ColorMapper(JSProxy): port to QJSEngine/QJSValue API git bisect bad a99fd387c3b4d70740b3956bc9e21538eb0f62f6 # skip: [7c65f81c18e8fe07efc2d139eb7fb61d2f0e74ea] Fix usage of deprecated parameter git bisect skip 7c65f81c18e8fe07efc2d139eb7fb61d2f0e74ea # skip: [4e1d5440f585c4e180e825c853fe89da049607bf] Remove warning in ControllerEngine git bisect skip 4e1d5440f585c4e180e825c853fe89da049607bf # skip: [630c7815e4ffdcb12f345d42aae72a242cba9585] Replace tabs with spaces git bisect skip 630c7815e4ffdcb12f345d42aae72a242cba9585 # skip: [907d9dfa82d3f062209b50cbfc37e02c77dddbef] Rename internalExecute and remove execute methods git bisect skip 907d9dfa82d3f062209b50cbfc37e02c77dddbef # skip: [cc13e7c6b8769330fe711b3a15e00efd6532f3f1] Merge branch 'master' into migrate-to-QJSEngine git bisect skip cc13e7c6b8769330fe711b3a15e00efd6532f3f1 # skip: [70ed3c934f4baead6cf902801c711a686a3a8018] Fix log message git bisect skip 70ed3c934f4baead6cf902801c711a686a3a8018 # skip: [d572eb1c7f36584c0ba6b84355fd19fb60ec7009] Let subclasses of Controller provide custom JS api git bisect skip d572eb1c7f36584c0ba6b84355fd19fb60ec7009 # skip: [e0295ad6614e20bab3f1093e9ab79f2057f2b80a] Add script error dialog on executeFunction and ScriptConnection git bisect skip e0295ad6614e20bab3f1093e9ab79f2057f2b80a # skip: [d9013e8dac69a0f18cd008bfb459c5315bc5048f] Replace tabs with spaces git bisect skip d9013e8dac69a0f18cd008bfb459c5315bc5048f # skip: [3337dfdef60a26e84cd39ad9556e3e869b539320] Remove controllerengineexceptions.h git bisect skip 3337dfdef60a26e84cd39ad9556e3e869b539320 # skip: [d6d86e8926bd50ec093b929d0e28a23fad10d5d8] Merge branch 'master' into migrate-to-QJSEngine git bisect skip d6d86e8926bd50ec093b929d0e28a23fad10d5d8 # skip: [075664d79281ad4be7fc6e4daa1938c706e7492f] Evaluate timer callback strings on beginTimer git bisect skip 075664d79281ad4be7fc6e4daa1938c706e7492f # skip: [f6291d794e9030230d67a523d115a53a66b43798] Add missing Q_OBJECT macro git bisect skip f6291d794e9030230d67a523d115a53a66b43798 # skip: [2deded5d42f2b87b87d2d2ae00d4427a98868dd6] Merge branch 'master' into migrate-to-QJSEngine git bisect skip 2deded5d42f2b87b87d2d2ae00d4427a98868dd6 # skip: [6f5dfd2a37e2ddad77db6614df4fe157eba791c9] Add HidControllerJSProxy git bisect skip 6f5dfd2a37e2ddad77db6614df4fe157eba791c9 # skip: [4fa82f7fd949b0f29d8d2d2951e38ac57e4425c8] Remove m_bPopups git bisect skip 4fa82f7fd949b0f29d8d2d2951e38ac57e4425c8 # skip: [3ca5bfd18bfe4ed14bb2bcb6c51567651951fa29] Disconnect DlgPreferences::changePage before deleting controller delegates git bisect skip 3ca5bfd18bfe4ed14bb2bcb6c51567651951fa29 # skip: [80263a9ccf9b2cd546be7fdd9987ff0b4158a9e1] Rename variable git bisect skip 80263a9ccf9b2cd546be7fdd9987ff0b4158a9e1 # skip: [c7dd4db746feeaee94ad71642673375320f2ac07] Disable apply and accept buttons when loading an incompatible mapping git bisect skip c7dd4db746feeaee94ad71642673375320f2ac07 # bad: [e5984a69282211b3144d087aaf6b6fc41eef0117] Merge branch 'master' of github.com:mixxxdj/mixxx into migrate-to-QJSEngine git bisect bad e5984a69282211b3144d087aaf6b6fc41eef0117 # skip: [06ad456f35311a1fdc5ad707ed6d57e083a734bc] Merge branch 'master' into migrate-to-QJSEngine git bisect skip 06ad456f35311a1fdc5ad707ed6d57e083a734bc # good: [381214a6d13a01cae53403f1390592318ff7b62a] Fix wrong file path in scons git bisect good 381214a6d13a01cae53403f1390592318ff7b62a # bad: [863b59c6c12eac8dc9c0c86607f2b64b08cb2a0f] Merge branch 'migrate-to-QJSEngine' of https://github.com/ferranpujolcamins/mixxx into migrate-to-QJSEngine git bisect bad 863b59c6c12eac8dc9c0c86607f2b64b08cb2a0f # skip: [9b658d10124eb9c43816c380d09d1254a4ebc263] Merge branch 'master' of github.com:mixxxdj/mixxx into migrate-to-QJSEngine git bisect skip 9b658d10124eb9c43816c380d09d1254a4ebc263 # only skipped commits left to test # possible first bad commit: [863b59c6c12eac8dc9c0c86607f2b64b08cb2a0f] Merge branch 'migrate-to-QJSEngine' of https://github.com/ferranpujolcamins/mixxx into migrate-to-QJSEngine # possible first bad commit: [9b658d10124eb9c43816c380d09d1254a4ebc263] Merge branch 'master' of github.com:mixxxdj/mixxx into migrate-to-QJSEngine