script to create inverted colors skins, and a LateDay skin

[michelealbano]

I developed a python script that visits the folders containing a skin, and re-creates in the current folder the same folder structure, copies locally the png / psd files, and for everything else it copies the files but inverts the colors.

This PR could solve issue #9217

[ronso0]

Interesting! (I didn't look into the details, yet. )

In general the easiest way to fix #9217 would be another color scheme for an existing skin (for LateNight preferrably). Creating yet another skin increases the maintenance burden, especially if we just duplicate an existing skin.

Could you look into making the script work with the existing LateNight architecture and use the PaleMoon scheme?
Each scheme has a

• Scheme section in skin.xml https://github.com/mixxxdj/mixxx/blob/2.4/res/skins/LateNight/skin.xml#L125-L234
• style subdirectory https://github.com/mixxxdj/mixxx/tree/2.4/res/skins/LateNight/palemoon
• a stylesheet that complements the basic stylesheet style.qss https://github.com/mixxxdj/mixxx/blob/2.4/res/skins/LateNight/style_palemoon.qss

[michelealbano]

As suggested, I have no new skin anymore, but a color scheme for LateNight. Solving #9217 possibly

[ronso0]

Thank you, I'll check this out next days.

I think this can go into the 2.4 branch.
Also there are quite a few unrelated changes in skin.xml that indicate you worked off the 2.3 branch (or an older version of the main branch?). Please take a look, rebase if required and force-push so we can change the target branch here.

[michelealbano]

Should I checkout main, or 2.4? Michele

…

On Fri, Jun 9, 2023 at 2:27 PM ronso0 ***@***.***> wrote: Thank you, I'll check this out next days. I think this can go into the 2.4 branch. Also there are quite a few unrelated changes in skin.xml that indicate you worked off the 2.3 branch (or an older version of the main branch?). Please take a look, rebase if required and force-push so we can change the target branch here. — Reply to this email directly, view it on GitHub <#11638 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC66LHHYSVI7BSKTFDVLZWTXKMJDHANCNFSM6AAAAAAZAMLKNE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[daschuer]

Skin changes can go to 2.4-beta. Release is scheduled at 2023-08-08 so no stress, if you miss that date we will merge it to 2.5 which will be released 6 month later.
Target your work at the 2.4 branch in any case.

Just last weekend it was itching me that the Shade skin is good for sunlight, but the library is not.

I did not had a look to the script, is it similar to the color shema implementation of Shade? In that case, the colors from the PNGs are replaced on the fly. However recalculating the colors from the library css is missing.

Can you script help here?

[ronso0]

@michelealbano When you rebase could you please separate the changes into

• add script
• add PaleSun scheme

The color inversion seems to work but the theme itself is not usable IMO

• most button icons are hard to recognise, the dark outlines that should increase local contrast now make the icons appear muddy
• text/background contrast is as low (or even lower?) as in PaleMoon, but for daylight we need high contrast
• knobs are hard to read

Bottom line: simply inverting the colors doesn't produce a daylight skin. I think the issue is that the script handles all colors the same way (or misses some SVG colors?) and can't really replace manual labor.
I chose distinct colors in most places (e.g. #000001 instead of #000) so they can be bulk-changed with simple find & replace scripts, for example the icon shadows, the button borders etc.

[michelealbano]

I think part of the problem is that in the original theme (palemoon) you use shorter color codes, for example #1000 instead of #1000, thus the script cannot recognize all the color codes.

…

On Mon, Jun 12, 2023 at 11:26 PM ronso0 ***@***.***> wrote: @michelealbano <https://github.com/michelealbano> When you rebase could you please separate the changes into - add script - add PaleSun scheme The color inversion seems to work but the theme itself is not usable IMO - most button icons are hard to recognise, the dark outlines that should increase local contrast now make the icons appear muddy - text/background contrast is as low (or even lower?) as in PaleMoon, but for daylight we need high contrast - knobs are hard to read [image: image] <https://user-images.githubusercontent.com/5934199/245282383-582d0fcd-ea83-472e-8fde-25936b964766.png> [image: image] <https://user-images.githubusercontent.com/5934199/245281574-34fab8bb-3286-4560-9459-d44a4d7b07d9.png> Bottom line: simply inverting the colors doesn't produce a daylight skin. I think the issue is that the script handles all colors the same way (or misses some SVG colors?) and can't really replace manual labor. I chose distinct colors in most places (e.g. #1 instead of #000) so they can be bulk-changed with simple find & replace scripts, for example the icon shadows, the button borders etc. — Reply to this email directly, view it on GitHub <#11638 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC66LHDG6RX4JXRO7N442SLXK6CQXANCNFSM6AAAAAAZAMLKNE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ronso0]

Yeah, this may be due to the scour SVG optimization.

[michelealbano]

Hi, I found a way to improve my script + the skin. Please check it out. Best, Michele

…

On Mon, Jun 12, 2023 at 11:59 PM ronso0 ***@***.***> wrote: Yeah, this may be due to the scour SVG optimization. — Reply to this email directly, view it on GitHub <#11638 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC66LHALOHOG2LF27KQUPHTXK6GMBANCNFSM6AAAAAAZAMLKNE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[JoergAtGithub]

Link to new PR: #11747