Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash due to dangling pointer access in developer mode. #13889

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

daschuer
Copy link
Member

This fixes a regression #13885 since #12094

@daschuer daschuer changed the base branch from main to 2.5 November 15, 2024 09:45
@daschuer daschuer added this to the 2.5.0 milestone Nov 15, 2024
@daschuer
Copy link
Member Author

Done

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@JoergAtGithub
Copy link
Member

@daschuer Thank you for jumping in! The fix LGTM and I just tested it on Win11 -> Works as expected!

@JoergAtGithub JoergAtGithub merged commit 1dd7e0a into mixxxdj:2.5 Nov 16, 2024
13 checks passed
@ronso0
Copy link
Member

ronso0 commented Nov 16, 2024

Thanks @daschuer for quick fix!
Can confirm it doesn't crash anymore.

However, I want to note that I saw the crash for other event types, too, eg. QChildEvent(ChildRemoved, ..).
So, presuming

shall we tie to another developer option, eg. a certain log level?

@JoergAtGithub
Copy link
Member

However, I want to note that I saw the crash for other event types, too, eg. QChildEvent(ChildRemoved, ..).

Than I see only two options:

  1. Cache the object informantion before calling notify, which will affect the general performance in developer mode
  2. Remove the printout of the target object information and just print the information about the event type

@ronso0
Copy link
Member

ronso0 commented Nov 17, 2024

  1. implementing Display MIDI Through device in non-developer mode #8356 would "fix" it IMO since this eliminates the only reason I know to run Mixxx with --developer in regular sessions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants