-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hotcue Button colors to skins #2120
Conversation
81d4330
to
d5b7ab7
Compare
ced0abc
to
87dbea2
Compare
I also added support for colored buttons to the other skins (except LateNight). |
This depends on patches from PR mixxxdj#2120 to work.
@uklotzde IMHO this PR is ready. The only skin missing is the |
Good job, this PR looks good and it's a long awaited feature! Can you tweak the default hotcue mark color on Tango and Deere so it matches the default color of the hotcue button? |
@ferranpujolcamins Done. |
LGTM |
LGTM. Very helpful, especially in conjunction with the auto-assignment of cue colors! |
LateNight is addressed in #2205 |
@Holzhaus Could you explain which hotcue state [displayValue="2"] should address? |
@Holzhaus |
If the qss is okay, maybe the widget is not re-polished? But that shouldn't be skin-dependent... |
This gives skins the ability to show Hotcue Button colors and adds support for that feature to the Deere skin. I used to colors from PR #2031 (and just added
0x20
to the dominant RGB channels for hover colors).This resolves Launchpad Bug lp1829884 (but only partially, since I only adapted the Deere skin).
Here's a screenshot: