Latenight :: implement hotcue colors #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ronso0
commented
Jul 16, 2019
ronso0
commented
- use transparent bg SVGs for set/unset & pressed/unpressed states
- define bg color in css
- adapt changes to in/outro cues as well, match colors to waveform markers
- align hotcue numbers right to waveform markers
…hotcue number vectors in order to make individual hotcue buttons stylable via css by binding button bg color to 'highlight' connection [ChannelN],hotcue_N_color_id). default is red, like before.
|
Looks good, howerver there is an issue with the no color cues. Their buttons are red, but the waveforms marker is green. |
|
red was the default, so I'll change the marker color so that it fits and is still ready to recognize |
This was referenced Jul 17, 2019
by moving all bg colors to css, thus icons set/unset state are identical now
|
Thank you, better now. LGTM. Ready to merge? |
|
jup, ready to merge. I had to pace myself and not tweak Cue, Play and other buttons the same way... |
|
Thank you. |
|
this closes https://bugs.launchpad.net/mixxx/+bug/1829884 if I am not mistaken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.