Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skin: Move legacy skin classes to skin/legacy/ #3912

Merged
merged 1 commit into from
May 25, 2021

Conversation

Holzhaus
Copy link
Member

No description provided.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I am unsure about the pre-commit issues. Do you want to add a commit with these automatic changes to avoid future noise in PRs? I don't mind about the listed issues itself.

@Holzhaus
Copy link
Member Author

I can, but we usually had the policy to not do mass reformattings, so I intentionally skipped it. If you want, I can add it.

@Holzhaus
Copy link
Member Author

I can, but we usually had the policy to not do mass reformattings, so I intentionally skipped it. If you want, I can add it.

So... Should I? @daschuer @uklotzde ?

@uklotzde
Copy link
Contributor

I don't mind. Choose whatever you think is reasonable and doesn't waste your precious time ;)

@daschuer
Copy link
Member

Oh I see. I Initially thought it was only header sorting. That would be to massive.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daschuer daschuer merged commit b1cab0d into mixxxdj:2.3 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants