Release 1.0.0 (with breaking changes)

[oliverklee]

This would allow Semantic Versioning to finally make sense for this package.

These are the things I'd like to get in for 1.0.0:

• Set PHP 7.1 as minimum required version #111 require PHP >= 7.1
• Update PHPUnit to Version 7.x #112 upgrade PHPUnit
• Use strict types #133 use strict types
• Add return types and nullable types #134 add return types and nullable types
• Fix the return type of ZipResponse::getCsvResponse #124 Fix the return type of ZipResponse::getCsvResponse

[mjaschen]

The perfect moment for that would be after dropping PHP 7.0 ;-)

[Argee88]

As long as not all collmex-endpoints are implemented, I don't feel like there should be a major release

[oliverklee]

@Argee88 Are you familiar with semantic versioning? If not, you might want to take a look at https://semver.org/ .

[mjaschen]

@Argee88 We cannot ensure that all endpoints are implemented at any given time because Collmex permanently adds new ones. Adding new endpoints wouldn't break the API in a backwards incompatible way, therefore I don't see a problem in releasing a 1.0.0.

[Argee88]

Okay, I won't put up a fight ;)
However, I was talking about the existing ones and not about future changes to the API. Of course, you have to find a point, where you make a major release...

[oliverklee]

@mjaschen Would you be willing to add the changes from 0.11.1 and 0.12.0 to the changelog in the meantime?

[mjaschen]

I'm on it.

[oliverklee]

I also propose we add the corresponding lines from the changelog to the releases here in GitHub. Then the releases will look like this or this:

• https://github.com/MyIntervals/emogrifier/releases
• https://github.com/oliverklee/ext-seminars/releases

[Argee88]

Hi!
When will the release of 1.0 be? Since #179 is resolved I'd like to use it right away beacause this is a security update...

[oliverklee]

@Argee88 Just for the record: #178 isn't a security update.

[Argee88]

Never talked about #178 though... And the one I talked about actually is...

[oliverklee]

Oh, sorry, my bad. It was a typo. I actually indeed meant that #179 isn't a security fix (in the sense that it fixes a vulnerability).

[Argee88]

Yeah, no. Anywho, I'd like to get an estimated date, which was the initial question

[oliverklee]

@mjaschen I think the project now is ready for version 1.0.0. If everything is okay from your side as well, could you please release during the next few days? Thanks!

[oliverklee]

1.0.0 is out of the door. 🎆