From 19a7177b7b2782b5aa88e85e724e40911be4e3fc Mon Sep 17 00:00:00 2001 From: ssss141414 Date: Tue, 19 Jan 2021 16:02:04 +0800 Subject: [PATCH] [Hub Generated] Review request for Microsoft.BotService to add version stable/2020-06-02 (#12433) * fix live validation * remove R4010 * suppress * suppress * suppress * suppress * suppress * suppress * suppress * suppress * suppress * suppress * suppress * suppress * suppress * suppress * suppress --- .../stable/2020-06-02/botservice.json | 4 ++-- .../stable/2020-06-02/examples/GetConnection.json | 2 +- specification/botservice/resource-manager/readme.md | 12 +++++++----- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/specification/botservice/resource-manager/Microsoft.BotService/stable/2020-06-02/botservice.json b/specification/botservice/resource-manager/Microsoft.BotService/stable/2020-06-02/botservice.json index 917facac9676..c5efb45ca635 100644 --- a/specification/botservice/resource-manager/Microsoft.BotService/stable/2020-06-02/botservice.json +++ b/specification/botservice/resource-manager/Microsoft.BotService/stable/2020-06-02/botservice.json @@ -806,7 +806,7 @@ } } }, - "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/botServices/{resourceName}/Connections/{connectionName}/listWithSecrets": { + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/botServices/{resourceName}/connections/{connectionName}/listWithSecrets": { "post": { "tags": [ "BotConnection" @@ -851,7 +851,7 @@ } } }, - "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/botServices/{resourceName}/Connections/{connectionName}": { + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/botServices/{resourceName}/connections/{connectionName}": { "put": { "tags": [ "BotConnection" diff --git a/specification/botservice/resource-manager/Microsoft.BotService/stable/2020-06-02/examples/GetConnection.json b/specification/botservice/resource-manager/Microsoft.BotService/stable/2020-06-02/examples/GetConnection.json index c43963179c9c..d2bb5e7ba2b6 100644 --- a/specification/botservice/resource-manager/Microsoft.BotService/stable/2020-06-02/examples/GetConnection.json +++ b/specification/botservice/resource-manager/Microsoft.BotService/stable/2020-06-02/examples/GetConnection.json @@ -10,7 +10,7 @@ "200": { "body": { "location": "global", - "id": "/subscriptions/subscription-id/resourceGroups/OneResourceGroupName/providers/Microsoft.BotService/botServices/samplebotname/Connections/sampleConnection", + "id": "/subscriptions/subscription-id/resourceGroups/OneResourceGroupName/providers/Microsoft.BotService/botServices/samplebotname/connections/sampleConnection", "etag": "etag1", "name": "sampleConnection", "properties": { diff --git a/specification/botservice/resource-manager/readme.md b/specification/botservice/resource-manager/readme.md index 94193fa33303..6e1824037d67 100644 --- a/specification/botservice/resource-manager/readme.md +++ b/specification/botservice/resource-manager/readme.md @@ -36,7 +36,11 @@ These settings apply only when `--tag=package-2020-06-02` is specified on the co ```yaml $(tag) == 'package-2020-06-02' input-file: - - Microsoft.BotService/stable/2020-06-02/botservice.json +- Microsoft.BotService/stable/2020-06-02/botservice.json +directive: + - suppress: R4009 + from: botservice.json + reason: We do not yet support systemdata. ``` @@ -109,10 +113,8 @@ swagger-to-sdk: ``` directive: - suppress: SECRET_PROPERTY - from: - - Microsoft.BotService/stable/2020-06-02/botservice.json - where: - - $.definitions.FacebookChannelProperties.properties.verifyToken + from: botservice.json + where: $.definitions.FacebookChannelProperties.properties.verifyToken reason: We do need to return verifyToken in FacebookChannelProperties. ```