-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add load_git, to load Module from a git committish #76
Conversation
Fixed up docstrings and checks... and created a better test fixture strategy. Note, I had to |
Thanks, I didn't get the time to review yet, but soon 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done! Mostly good, just one or two questions, and some nitpicks about file structure 🙂
all set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK! Thanks a lot! This paves the way to great things 😎
Since you mentioned liking the module-from-git approach in griffediff. Here's a PR for your consideration that adds it here. This will create a temporary git worktree with a specific commit or tag checked out, then add it to the search_paths passed to the loader
leaving in draft for now, as i'm sure there's some stuff to discuss (and I haven't run all the checks yet).