This repository has been archived by the owner on Nov 20, 2019. It is now read-only.
Fail to submit comment #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mknapik
commented
Oct 18, 2016
| end | ||
|
|
||
| begin | ||
| require 'rubocop/rake_task' | ||
| RuboCop::RakeTask.new(:rubocop) | ||
| rescue LoadError # rubocop:disable Lint/HandleExceptions | ||
| rescue LoadError |
There was a problem hiding this comment.
Do not suppress exceptions.
mknapik
commented
Oct 18, 2016
| end | ||
|
|
||
| task default: [:spec, :rubocop] | ||
| task default: [:spec, :rubocop] |
mknapik
commented
Oct 18, 2016
| @@ -1,8 +1,15 @@ | |||
| # frozen_string_literal: true | |||
| # Docs | |||
| class Fibonacci | |||
|
|
|||
There was a problem hiding this comment.
Extra empty line detected at class body beginning.
mknapik
commented
Oct 18, 2016
| @@ -1,8 +1,15 @@ | |||
| # frozen_string_literal: true | |||
| # Docs | |||
| class Fibonacci | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Extra blank line detected.
mknapik
commented
Oct 18, 2016
| def self.call(n) | ||
|
|
There was a problem hiding this comment.
Extra empty line detected at method body beginning.
mknapik
commented
Oct 18, 2016
| Hash.new { |hash, key| hash[key] = hash[key - 2] + hash[key - 1] } | ||
| .tap { |hash| hash[0] = hash[1] = 1 }[n] | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
Extra blank line detected.
mknapik
commented
Oct 18, 2016
| Hash.new { |hash, key| hash[key] = hash[key - 2] + hash[key - 1] } | ||
| .tap { |hash| hash[0] = hash[1] = 1 }[n] | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
Extra empty line detected at class body end.
mknapik
commented
Oct 18, 2016
| end | ||
|
|
There was a problem hiding this comment.
2 trailing blank lines detected.
mknapik
force-pushed
the
nil_comments
branch
2 times, most recently
from
9297209 to
c26ab73
Compare
mknapik
commented
Oct 18, 2016
| @@ -3,15 +3,15 @@ | |||
| begin | |||
| require 'rspec/core/rake_task' | |||
| RSpec::Core::RakeTask.new(:spec) | |||
| rescue LoadError # rubocop:disable Lint/HandleExceptions | |||
| rescue LoadError | |||
There was a problem hiding this comment.
Do not suppress exceptions.
mknapik
commented
Oct 18, 2016
| end | ||
|
|
||
| begin | ||
| require 'rubocop/rake_task' | ||
| RuboCop::RakeTask.new(:rubocop) do |task| | ||
| task.fail_on_error = false | ||
| end | ||
| rescue LoadError # rubocop:disable Lint/HandleExceptions | ||
| rescue LoadError |
There was a problem hiding this comment.
Do not suppress exceptions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the second run:
See travis log