Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up #26

Open
mkraska opened this issue Jan 7, 2023 · 1 comment
Open

Clean up #26

mkraska opened this issue Jan 7, 2023 · 1 comment
Labels
Maintenance Refactoring, unit tests etc.

Comments

@mkraska
Copy link
Owner

mkraska commented Jan 7, 2023 •
edited
Loading

Adjust the code of meclib.js to JS coding standards.

  • replace var by let
  • class names starting with capital letters
  • strict comparisons with ===
  • make findConnectingLines() a method of class polygon (instead of a global function)

Change Maxima comments in functions from block comments /* / to line comments. This is because nesting of block comments doesnt work. Local copies of functions with block comments can't be switched on/off with block comments in the question variables.
@mkraska mkraska added the Maintenance Refactoring, unit tests etc. label Jan 23, 2023
@mkraska
Copy link
Owner Author

mkraska commented Dec 5, 2023

replacing var by let done by Aaron in iMeclib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintenance Refactoring, unit tests etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkraska