Bugfix default 0 values (#304)

Fixes default values set at `0` that were wrongly evaluated to `None`
ml6team · Jul 18, 2023 · 4e36e87 · 4e36e87
1 parent 335ca24
commit 4e36e87
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/fondant/executor.py b/src/fondant/executor.py
@@ -105,7 +105,7 @@ def _add_and_parse_args(cls, spec: ComponentSpec):
             if arg.name in cls.optional_fondant_arguments():
                 input_required = False
                 default = None
-            elif arg.default:
+            elif arg.default is not None:
                 input_required = False
                 default = arg.default
             else:

diff --git a/tests/example_specs/components/arguments/component.yaml b/tests/example_specs/components/arguments/component.yaml
@@ -10,7 +10,7 @@ args:
   integer_default_arg:
     description: default integer argument
     type: int
-    default: 1
+    default: 0
   float_default_arg:
     description: default float argument
     type: float

diff --git a/tests/test_component.py b/tests/test_component.py
@@ -106,7 +106,7 @@ def _process_dataset(self, manifest: Manifest) -> t.Union[None, dd.DataFrame]:
     executor = MyExecutor.from_args()
     assert executor.user_arguments == {
         "string_default_arg": "foo",
-        "integer_default_arg": 1,
+        "integer_default_arg": 0,
         "float_default_arg": 3.14,
         "bool_false_default_arg": False,
         "bool_true_default_arg": True,