Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaults to components #289

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Conversation

PhilippeMoussalli
Copy link
Contributor

PR that add default arguments to component yaml. This makes it easier to get started with default values for reusable components.

@PhilippeMoussalli PhilippeMoussalli self-assigned this Jul 11, 2023
@PhilippeMoussalli PhilippeMoussalli linked an issue Jul 11, 2023 that may be closed by this pull request
@PhilippeMoussalli PhilippeMoussalli added the Components Implementation of components label Jul 11, 2023
Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PhilippeMoussalli! I think you need to update the failing test.

@PhilippeMoussalli PhilippeMoussalli merged commit 86867a5 into main Jul 12, 2023
@PhilippeMoussalli PhilippeMoussalli deleted the update-component-defaults branch July 12, 2023 08:32
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
PR that add default arguments to component yaml. This makes it easier to
get started with default values for reusable components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Components Implementation of components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update component to use default argument where necessary
2 participants