[Datacomp] Add clean_captions and filter_clip_score components #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NielsRogge
approved these changes
Aug 23, 2023
RobbeSneyders
requested changes
Aug 23, 2023
There was a problem hiding this comment.
Thanks @alexanderremmerie
Can you just revert all the commit hashes in the component specs?
|
@RobbeSneyders I've reverted the commit hashes, but I have not yet had an experience where the dev tags work out of the box. I always need to rebuild the Docker images because the dev ones don't work |
|
We might want to implement this: #365 |
RobbeSneyders
approved these changes
Aug 24, 2023
RobbeSneyders
changed the title
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
Co-authored-by: Niels Rogge <niels.rogge1@gmail.com> Co-authored-by: Robbe Sneyders <robbe.sneyders@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.