Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes explorer #446

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Small fixes explorer #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/fondant/explorer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ def run_explorer_app( # type: ignore
cmd = [
"docker",
"run",
"--pull",
"always",
"--name",
"fondant-explorer",
"--rm",
Expand Down Expand Up @@ -58,7 +60,7 @@ def run_explorer_app( # type: ignore

# Mount the local base path to the container
cmd.extend(
["-v", f"{shlex.quote(host_machine_path)}:{shlex.quote(container_path)}"],
["-v", f"/{shlex.quote(host_machine_path)}:/{shlex.quote(container_path)}"],
)

# add the image name
Expand Down
6 changes: 5 additions & 1 deletion tests/test_explorer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ def test_run_data_explorer_local_base_path(host_path, container_path, credential
[
"docker",
"run",
"--pull",
"always",
"--name",
"fondant-explorer",
"--rm",
Expand All @@ -54,7 +56,7 @@ def test_run_data_explorer_local_base_path(host_path, container_path, credential
"-v",
f"{credentials}:ro",
"-v",
f"{Path(host_path).resolve()}:{container_path}",
f"/{Path(host_path).resolve()}:/{container_path}",
f"{DEFAULT_CONTAINER}:{DEFAULT_TAG}",
"--base_path",
f"{container_path}",
Expand All @@ -78,6 +80,8 @@ def test_run_data_explorer_remote_base_path(remote_path, credentials):
[
"docker",
"run",
"--pull",
"always",
"--name",
"fondant-explorer",
"--rm",
Expand Down
Loading