Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MinGW requiring fpermissive to compile #62

Closed
wants to merge 1 commit into from
Closed

Fix MinGW requiring fpermissive to compile #62

wants to merge 1 commit into from

Conversation

ncruces
Copy link

@ncruces ncruces commented Jan 23, 2019

This is the error I get otherwise:

../../src/nfd_win.cpp: In function 'nfdresult_t NFD_OpenDialog(const nfdchar_t*, const nfdchar_t*, nfdchar_t**)':
../../src/nfd_win.cpp:448:1: error: jump to label 'end' [-fpermissive]
 end:
 ^~~
../../src/nfd_win.cpp:379:14: note:   from here
         goto end;
              ^~~
../../src/nfd_win.cpp:383:13: note:   crosses initialization of 'HRESULT result'
     HRESULT result = ::CoCreateInstance(::CLSID_FileOpenDialog, NULL,
             ^~~~~~

Error message: jump to label 'end' crosses initialization of 'HRESULT result'.
@ncruces
Copy link
Author

ncruces commented Jan 25, 2019

Closing, hadn't seen Submitting Pull Requests.

Branches are even, but I'll stick to the rules: #63

@ncruces ncruces closed this Jan 25, 2019
@ncruces ncruces deleted the patch-1 branch October 8, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant