Add nlp blogpost #23
Open
Add nlp blogpost #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinjaggi
reviewed
Oct 8, 2020
tvogels
reviewed
Oct 12, 2020
There was a problem hiding this comment.
Hi @ehoelzl, @martinjaggi asked me to go over the blog post and leave a review.
Interesting results. I also like the overall tone of the blog post.
My comments are a mix of reformulation suggestions to make things more concise, terminology confusion, and a thing or two about the presentation of the results. Hope this is helpful.
added 2 commits
October 30, 2020 13:32
|
@martinjaggi @tvogels Could you review the updates please ? Thanks |
martinjaggi
reviewed
Feb 26, 2021
|  | ||
| *Step times for Transformer* | ||
| <a href="{{ site.baseurl }}public/images/blog/2020-10-02-nlp-translation/task4b_step_shares.png" data-lightbox="task4b_step_shares" data-title="Step shares for Transformer"> | ||
| *Step shares for Transformer* |
There was a problem hiding this comment.
is a 'step share' a communication step? maybe better to call it that in the text?
|
very nice!
i left minor cosmetic comments
…On Fri, Feb 26, 2021 at 3:42 PM Edoardo Holzl ***@***.***> wrote:
@martinjaggi <https://github.com/martinjaggi> @tvogels
<https://github.com/tvogels> Could you review the updates please ? Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDIMR6S3CJBAABIFK4HQ63TA6XMDANCNFSM4SHSCTJQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15