Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version meta tag #319

Merged
merged 1 commit into from
Nov 6, 2024
Merged

add version meta tag #319

merged 1 commit into from
Nov 6, 2024

Conversation

niquerio
Copy link
Collaborator

@niquerio niquerio commented Nov 5, 2024

Adds version meta tag. This will expose the version of the site so you can verify which image is running without checking kubernetes or argocd.

This changes makes it so that the application exposes the value in the environment variable APP_VERSION through the version meta tag. In development this is always APP_VERSION. In kubernetes, this is inserted at kubernetes application time, and is the tag of the app image. The tag is either the release version (in production for stable images) or the commit hash (in not-production for unstable images).

The development version doesn't try to calculate the version because it'd be somewhat complex logic relying on git cli commands, and it's not the right place for this logic in the first place. We want to insert the image information and that information comes from outside of the application. So, when viewing the site on localhost, the version will always show APP_VERSION, and it is supposed to do that.

Copy link
Collaborator

@erinesullivan erinesullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 I see the meta tag.

@niquerio niquerio merged commit 149980e into main Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants