From 3db69493f61a0d33809e28b118f1eb645345fd7d Mon Sep 17 00:00:00 2001 From: Michele Locati Date: Sat, 16 Nov 2024 18:36:33 +0100 Subject: [PATCH] Check syntax with PHP 8.4 --- .github/workflows/check-syntax.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/check-syntax.yml b/.github/workflows/check-syntax.yml index fc17d8bf9c6..9fb8980991f 100644 --- a/.github/workflows/check-syntax.yml +++ b/.github/workflows/check-syntax.yml @@ -6,8 +6,14 @@ on: jobs: check-syntax: - name: PHP + name: PHP ${{ matrix.php-version }} runs-on: ubuntu-latest + strategy: + matrix: + php-version: + # This list should include at least the value of Concrete\Core\Install\Preconditions\PhpVersion::MINIMUM_PHP_VERSION + - "7.3" + - "8.4" steps: - name: Checkout @@ -16,14 +22,13 @@ jobs: name: Install PHP uses: shivammathur/setup-php@v2 with: - # This should be the value of Concrete\Core\Install\Preconditions\PhpVersion::MINIMUM_PHP_VERSION - php-version: 7.3 + php-version: ${{ matrix.php-version }} extensions: opcache coverage: none tools: none - name: Check syntax - uses: mlocati/check-php-syntax@main + uses: mlocati/check-php-syntax@v1 with: directory: concrete include: |