-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error setting theme #2
Comments
Do you know what version of PSReadline you are using? It is more than likely the 2.0.0 version. There were significant changes to that version that this module is not currently compatible with. I have been working on modifying PSConsoleTheme to work with it. I might publish a pre-release version to support users who are using the 2.0.0 beta. |
Thanks for the quick reply. I am using version 2.0.0. I suspected based on the error that this was the likely cause. If you do a pre-release I would love to test it out.
Thanks,
Nick Gosney
…________________________________
From: Michael Mims <notifications@github.com>
Sent: Monday, July 16, 2018 9:39 AM
To: mmims/PSConsoleTheme
Cc: ngosney; Author
Subject: Re: [mmims/PSConsoleTheme] Error setting theme (#2)
Do you know what version of PSReadline you are using? It is more than likely the 2.0.0 version. There were significant changes to that version that this module is not currently compatible with. I have been working on modifying PSConsoleTheme to work with it. I might publish a pre-release version to support users who are using the 2.0.0 beta.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#2 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AnYmTJdkufPAFVlFX3Gw6xSnw0p_A4Zwks5uHKWwgaJpZM4VRO_T>.
|
Absolutely, I will let you know when it is available. |
I'm having this problem too! Please advise. |
I've looked into this some more and there are significant issues with the way PSReadline handles colors in the 2.0.0 beta. The most difficult issue is that it does not honor light backgrounds. The resulting experience with PSConsoleTheme is less than optimal and is inconsistent with the experience with PSReadline 1.x. Because of this inconsistency, I don't feel comfortable releasing a beta to address this until the behavior is a little more consistent. I will submit an issue to the PSReadline project, and hopefully it will be addressed soon. However, I don't know what the roadmap for 2.0 is. |
there are some changes in 19H1 build. |
Unfortunately I am still receiving the same error message. Is this something that you will need to fix in the module? |
I have a workaround for the 1809 release which is to uninstall PSReadLine v2 (by removing the module folder) and then install-module v1.2. That said I'm not a massive PSReadLine user, so there may be functionality that I've lost but am not aware of. |
I've never quite understood why newer versions of Windows 10 have a beta version of the PSReadLine module. The biggest difference between 1.x and 2.x is support for Powershell Core and VT escape sequences. The signatures for several cmdlets also changed, but overall you shouldn't lose anything by going to v1.2. |
I have added a pre-release version that supports PSReadline 2.0. The issue with "light" themes still exists, but you shouldn't have any issues if you are using a dark theme. The v0.6.0-alpha1 pre-release is available on the releases page or through the powershell gallery:
Please provide any feedback here. |
Awesome, I'll try it out! Thanks for the update.
Regards,
Nick Gosney
On January 15, 2019 11:09:10 AM Michael Mims <notifications@github.com> wrote:
I have added a pre-release version that supports PSReadline 2.0. The issue with "light" themes still exists, but you shouldn't have any issues if you are using a dark theme. The v0.6.0-alpha1<https://github.com/mmims/PSConsoleTheme/releases/tag/v0.6.0-alpha1> pre-release is available on the releases page or through the powershell gallery:
Install-Module PSConsoleTheme -AllowPrerelease -Force
Please provide any feedback here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#2 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AnYmTKmsD6hyVODe5YLnydYhLoBIRXFLks5vDgszgaJpZM4VRO_T>.
|
the pre-release LGTM on PowerShell 6.1.1 |
works also fine on "classic" Windows PowerShell 5.1.17763.134 after manually upgrading PowershellGet via |
PS C:\WINDOWS\system32>
|
@rjt It appears you have an outdated version of the PowershellGet module. I believe Import-Module PowershellGet
Get-Module PowershellGet #shows the currently installed version
Find-Module PowershellGet #shows the most current version available
Install-Module PowershellGet -Force #update the module Restart your powershell session after updating the module and you should be able to install the prerelease version. |
Each time that I attempt to set a theme I always get the following error: "A parameter cannot be found that matches parameter name 'ContinuationPromptForegroundColor'." I am not sure if something changed in PSReadline or what. I am also attaching a screenshot in case it helps. Thanks!
The text was updated successfully, but these errors were encountered: