-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG, DOC: add EEG referencing tutorial #6648
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6648 +/- ##
==========================================
- Coverage 89.48% 89.48% -0.01%
==========================================
Files 420 420
Lines 75580 75582 +2
Branches 12381 12382 +1
==========================================
Hits 67635 67635
- Misses 5138 5139 +1
- Partials 2807 2808 +1 |
here's the revised rendering: https://14689-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/preprocessing/plot_55_setting_eeg_reference.html @wmvanvliet thanks for the feedback, I've re-worked the introduction and I think it's much improved. @cbrnr please check whether I've explained |
Yes, very nice! There's a small formatting error in "signal without restoring the signal at |
@cbrnr feel free to merge if you're happy. |
This should wait for a solution to #6647, which I hope to have today |
OK, please ping me if it works. |
Looks good so far. |
NB: after #6670 is merged, this should get rebased and have the Circle rendering checked. |
rebased to incorporate #6670, let's see if the docs look OK. |
@cbrnr this should be good to merge now. Here's the raw plots with titles: |
I've pushed a few minor improvements. This tutorial is really nice, there's just one point I'd like to see addressed before merging. The last section talks about why average referenced data is important for source imaging, but it strongly recommends the "average-reference-as-projection approach". However, the reasons given are just reasons for the average reference in general. I really miss an explanation why users should prefer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbrnr merge if you're happy
@cbrnr are you happy with the new wording? |
Yes! Thanks @drammock! |
* add EEG referencing tutorial * fix sentence fragment * clarify warning * WIP add section on custom refs * capitalization * fix ch. name too long * address Marijn's comments; fix discussion of mne.add_reference_channels * fix spelling typo * fix italics * make plots easier to read * STY: slightly better prose flow * address Jona's comments * address Clemens's comments; other minor tweaks * Minor improvements * clarify avg. ref. proj. reasoning
This is ready for review but should probably wait until a solution to #6647 is merged in.