diff --git a/.golangci.yml b/.golangci.yml index 119f4c7adbd1..bad084a5edb6 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -7,8 +7,6 @@ run: build-tags: - dfrunsecurity - - dfaddgit - - dfaddchecksum linters: enable: diff --git a/frontend/dockerfile/dockerfile2llb/convert.go b/frontend/dockerfile/dockerfile2llb/convert.go index 3deba448d92b..6d35d9c0e42e 100644 --- a/frontend/dockerfile/dockerfile2llb/convert.go +++ b/frontend/dockerfile/dockerfile2llb/convert.go @@ -1055,9 +1055,6 @@ func dispatchCopy(d *dispatchState, cfg copyConfig) error { if !cfg.isAddCommand { return errors.New("checksum can't be specified for COPY") } - if !addChecksumEnabled { - return errors.New("instruction 'ADD --checksum=' requires the labs channel") - } if len(cfg.params.SourcePaths) != 1 { return errors.New("checksum can't be specified for multiple sources") } @@ -1082,9 +1079,6 @@ func dispatchCopy(d *dispatchState, cfg copyConfig) error { if !cfg.isAddCommand { return errors.New("source can't be a git ref for COPY") } - if !addGitEnabled { - return errors.New("instruction ADD requires the labs channel") - } // TODO: print a warning (not an error) if gitRef.UnencryptedTCP is true commit := gitRef.Commit if gitRef.SubDir != "" { diff --git a/frontend/dockerfile/dockerfile2llb/convert_addchecksum.go b/frontend/dockerfile/dockerfile2llb/convert_addchecksum.go deleted file mode 100644 index 4506baeb8ba8..000000000000 --- a/frontend/dockerfile/dockerfile2llb/convert_addchecksum.go +++ /dev/null @@ -1,6 +0,0 @@ -//go:build dfaddchecksum -// +build dfaddchecksum - -package dockerfile2llb - -const addChecksumEnabled = true diff --git a/frontend/dockerfile/dockerfile2llb/convert_addgit.go b/frontend/dockerfile/dockerfile2llb/convert_addgit.go deleted file mode 100644 index 9ccb7a20e840..000000000000 --- a/frontend/dockerfile/dockerfile2llb/convert_addgit.go +++ /dev/null @@ -1,6 +0,0 @@ -//go:build dfaddgit -// +build dfaddgit - -package dockerfile2llb - -const addGitEnabled = true diff --git a/frontend/dockerfile/dockerfile2llb/convert_noaddchecksum.go b/frontend/dockerfile/dockerfile2llb/convert_noaddchecksum.go deleted file mode 100644 index 8de035297c1b..000000000000 --- a/frontend/dockerfile/dockerfile2llb/convert_noaddchecksum.go +++ /dev/null @@ -1,6 +0,0 @@ -//go:build !dfaddchecksum -// +build !dfaddchecksum - -package dockerfile2llb - -const addChecksumEnabled = false diff --git a/frontend/dockerfile/dockerfile2llb/convert_noaddgit.go b/frontend/dockerfile/dockerfile2llb/convert_noaddgit.go deleted file mode 100644 index 119bb32c8895..000000000000 --- a/frontend/dockerfile/dockerfile2llb/convert_noaddgit.go +++ /dev/null @@ -1,6 +0,0 @@ -//go:build !dfaddgit -// +build !dfaddgit - -package dockerfile2llb - -const addGitEnabled = false diff --git a/frontend/dockerfile/dockerfile_addchecksum_test.go b/frontend/dockerfile/dockerfile_addchecksum_test.go index 4d22d169946e..953ea43747bc 100644 --- a/frontend/dockerfile/dockerfile_addchecksum_test.go +++ b/frontend/dockerfile/dockerfile_addchecksum_test.go @@ -1,6 +1,3 @@ -//go:build dfaddchecksum -// +build dfaddchecksum - package dockerfile import ( diff --git a/frontend/dockerfile/dockerfile_addgit_test.go b/frontend/dockerfile/dockerfile_addgit_test.go index 8204eb73d8db..592c99dd8d4b 100644 --- a/frontend/dockerfile/dockerfile_addgit_test.go +++ b/frontend/dockerfile/dockerfile_addgit_test.go @@ -1,6 +1,3 @@ -//go:build dfaddgit -// +build dfaddgit - package dockerfile import ( diff --git a/frontend/dockerfile/docs/reference.md b/frontend/dockerfile/docs/reference.md index 1fa552f66209..e5154052a37e 100644 --- a/frontend/dockerfile/docs/reference.md +++ b/frontend/dockerfile/docs/reference.md @@ -1298,6 +1298,7 @@ guide – Leverage build cache](https://docs.docker.com/develop/develop-images/d > **Note** > > Not yet available in stable syntax, use [`docker/dockerfile:1-labs`](#syntax) version (`1.5-labs` or newer). +> Planned to be included in `docker/dockerfile:1.6`. The checksum of a remote file can be verified with the `--checksum` flag: @@ -1312,6 +1313,7 @@ The `--checksum` flag only supports HTTP sources currently. > **Note** > > Not yet available in stable syntax, use [`docker/dockerfile:1-labs`](#syntax) version (`1.5-labs` or newer). +> Planned to be included in `docker/dockerfile:1.6`. This form allows adding a git repository to an image directly, without using the `git` command inside the image: ``` diff --git a/frontend/dockerfile/release/labs/tags b/frontend/dockerfile/release/labs/tags index 71a17cb3926a..03dd8c3a5750 100644 --- a/frontend/dockerfile/release/labs/tags +++ b/frontend/dockerfile/release/labs/tags @@ -1 +1 @@ -dfrunsecurity dfaddgit dfaddchecksum +dfrunsecurity