Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache(gha): don't require url attr if url_v2 is set #5750

Merged
merged 1 commit into from
Feb 18, 2025
Merged

cache(gha): don't require url attr if url_v2 is set #5750

merged 1 commit into from
Feb 18, 2025

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Feb 17, 2025 •
edited
Loading

relates to docker/buildx#3001 (comment)

url will always be empty if cache service v2 is detected and url_v2 set.

@crazy-max
cache(gha): don't require url attr if url_v2 is set
3b4e28a 
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from tonistiigi February 17, 2025 17:47
@crazy-max crazy-max added this to the v0.20.0 milestone Feb 17, 2025
tonistiigi
tonistiigi approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buildx should send both url_v2 and url if there is a chance for error (at least temporarily).

@crazy-max
Copy link
Member Author

crazy-max commented Feb 18, 2025 •
edited
Loading

Buildx should send both url_v2 and url if there is a chance for error (at least temporarily).

Yes this is done in https://github.com/docker/buildx/pull/3001/files#diff-6bdb82b27c1a57d6c7f88f01076d5442e642c607508cc1ecc70be32da5735154R229-R233

@crazy-max crazy-max merged commit dae48b3 into moby:master Feb 18, 2025
104 checks passed
@crazy-max crazy-max deleted the fix-gha-cache-v2 branch February 18, 2025 08:23
@crazy-max crazy-max mentioned this pull request Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees
No one assigned
Labels
area/remotecache
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@crazy-max @tonistiigi