Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling of crammed widgets #99

Merged
merged 4 commits into from
Nov 27, 2019
Merged

Scrolling of crammed widgets #99

merged 4 commits into from
Nov 27, 2019

Conversation

mocdaniel
Copy link
Owner

7 lines of CSS in application.scss to allow the scrolling of widgets when they are crammed with entries. Especially useful for List and Simplelist widgets.

The changes do not affect the appearance of Dashing Icinga2. The scroll bars get pushed out of rendered areas by CSS for every browser and a widget's title and moreInfo sections stay where they are while scrolling content.

The functionality is enabled on a per-widget basis by adding the class=scrollable tag within their declarations in the respective dashboard.erb files.

Added CSS for scroll-ability of content if it is too much to fit the widget space
made `icinga-severity` scrollable for the demo dashboard.
Scrolling of crammed widgets
@dnsmichi dnsmichi added this to the 3.1.0 milestone Nov 21, 2019
@mocdaniel
Copy link
Owner Author

If requested for matters of consistency of configuration, I can also add a ruby method to config.ru which reads from config/icinga2.json and writes the class-declaration to the widgets when being called. (similar to the method which allows to get the time zone) from #94

@dnsmichi
Copy link
Collaborator

I don't mind making this the default. I prefer not to cause confusion with too many config options controlling the behaviour. A config setting always is last resort in contrast to pushing a wanted behaviour. Users who don't like it are still encouraged to edit the dashboard being only an example.

Copy link
Collaborator

@dnsmichi dnsmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch 👍

@dnsmichi dnsmichi merged commit 68cf8b2 into mocdaniel:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants