🐛 Bug: before() and after() hooks run in a test file with only skipped tests

[fabiosantoscode]

I recently stumbled upon this. A test file containing the following:

describe('something', () => {
  before(() => { console.log('I should really not run') })
  it.skip('skipped test', () => {})
  after(() => { console.log('I should really not run either') })
})

Will produce the following output:

  something
I should really not run
    - skipped test
I should really not run either


  0 passing (8ms)
  1 pending

The workaround is to skip the entire describe() instead of the individual tests, so I wonder if there's interest in fixing this. Should a before or after function be preparing or cleaning up a test which didn't run?

Thanks for this amazing piece of software ❤️

[boneskull]

This looks like an edge case... maybe not an easy fix either. We'd have to ensure that nowhere within a suite, at any nested level, there's a runnable test.

I'd accept a PR for this, but the solution would have to be pretty clean.

[lucasfcosta]

Hi @boneskull, I've been reading mocha's code for some time since I've also been dealing with Chai and I think I can make this pretty clear and straightforward.
Would you mind if I send an experimental PR in the next few days so we can talk about it?
Thanks in advance and keep on rocking, mocha is awesome 😄

[stale]

I am a bot that watches issues for inactivity.
This issue hasn't had any recent activity, and I'm labeling it stale. In 14 days, if there are no further comments or activity, I will close this issue.
Thanks for contributing to Mocha!