Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase contrast for replay buttons #4912

Merged
merged 2 commits into from
Sep 20, 2022
Merged

fix: increase contrast for replay buttons #4912

merged 2 commits into from
Sep 20, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 17, 2022 •
edited
Loading

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

Adds the increased visual emphasis as mentioned in #4911.

Light mode Dark mode
Light mode screenshot with more visible replay buttons Dark mode screenshot with more visible replay buttons

Alternate Designs

n/a

Why should this be in core?

n/a

Benefits

Users can more easily see the replay buttons.

Possible Drawbacks

n/a

Applicable issues

@juergba
Copy link
Contributor

juergba commented Aug 18, 2022

@JoshuaKGoldberg thank you.
IMO the result looks worse than before with the arrows being white now.

@JoshuaKGoldberg
Copy link
Member Author

Shoot, sorry @juergba - I switched them from black to #fff last minute, forgetting that it's #000 for black 🤦. Updated now.

@juergba
Copy link
Contributor

juergba commented Aug 28, 2022

@JoshuaKGoldberg the support for dark color scheme has been added recently. Please rebase and solve the conflicts, thanks.

juergba
juergba reviewed Sep 13, 2022
View reviewed changes
mocha.css Outdated Show resolved Hide resolved
@juergba juergba added area: browser browser-specific area: usability concerning user experience or interface semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Sep 13, 2022
@juergba juergba added this to the next milestone Sep 13, 2022
juergba
juergba approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshuaKGoldberg thank you for this PR.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.326% when pulling 0518abb on JoshuaKGoldberg:replay-button-accessibility into 41567df on mochajs:master.

@juergba juergba added the run-browser-test run browser tests on forked PR if code is safe label Sep 20, 2022
@github-actions github-actions bot removed the run-browser-test run browser tests on forked PR if code is safe label Sep 20, 2022
@juergba juergba merged commit 4e06a6f into mochajs:master Sep 20, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the replay-button-accessibility branch September 20, 2022 16:22
@JoshuaKGoldberg JoshuaKGoldberg restored the replay-button-accessibility branch September 20, 2022 16:22
@JoshuaKGoldberg JoshuaKGoldberg deleted the replay-button-accessibility branch September 20, 2022 16:22
@JoshuaKGoldberg JoshuaKGoldberg restored the replay-button-accessibility branch September 20, 2022 16:22
@JoshuaKGoldberg JoshuaKGoldberg deleted the replay-button-accessibility branch September 20, 2022 16:22
@juergba juergba added area: reporters involving a specific reporter and removed area: usability concerning user experience or interface labels Sep 20, 2022
@Grizzelbee Grizzelbee mentioned this pull request Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juergba juergba juergba approved these changes

Assignees
No one assigned
Labels
area: browser browser-specific area: reporters involving a specific reporter semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Milestone
v10.1.0
Development

Successfully merging this pull request may close these issues.

Inaccessible filter/replay buttons in browser reporter
3 participants
@JoshuaKGoldberg @juergba @coveralls