Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: When running Mojo.jar "expand" command, expand_size parameter documentation and default value.. #75

Open
jbreeher opened this issue Feb 24, 2021 · 1 comment

Comments

@jbreeher
Copy link

Doc states that

" expand_size Number of address to generate
Default: 0"

But when you run the command without specifying an expand_size you get:

java -jar mojo.jar expand -p "TestWallet1" testwallet1.mcm

Missing required parameter: expand_size

Currently, defaulting the value has no effect, since omitting the value causes the command to fail. Either simply require expand_size or remove the reference to default value. If the expand size is ommitted it should default to a number other than 0, which would do nothing. Possibly a 1 for automation (you expand the size before performing a transaction), thus always knowing there is available space.

@mochimodev
Copy link
Owner

@0rtis this is a good quality of life adjustment for mojo, when you have time to adjust it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants