-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support fully-qualified --package
arguments
#3563
Comments
Thank you for reporting this bug. We are trying to reproduce and investigate on our side. |
Hi @joshlf, I was able to reproduce the issue by cloning the version of the PR above, and this is indeed an issue with how we are handling the package argument. FYI, the ambiguity seems to be coming from the
Running cargo build fails with the same issue:
|
Ah yeah I suppose it's not actually Kani itself that has the zerocopy dep, but it's just that we need to be able to pass an unambiguous package spec via Kani. Thanks for looking into this! |
We were previously matching the name of the package, which would limit users if the name is ambiguous. Instead, use `cargo pkgid` to validate the `--package` argument and to retrieve the package id. Resolves #3563 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
We use Kani in zerocopy, and pass
--package zerocopy
in CI. However, on our 0.7 branch, we are encountering this failure:This seems to be due to Kani having a transitive dependency on zerocopy 0.7. However, Kani does not support passing either suggested syntax as an argument to the
--package
flag. If Kani supported--package path+file:///home/runner/work/zerocopy/zerocopy#0.7.35
, it would allow us to fix this failure.The text was updated successfully, but these errors were encountered: