Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More tests for exact_div #1007

Merged
merged 2 commits into from
Apr 11, 2022
Merged

More tests for exact_div #1007

merged 2 commits into from
Apr 11, 2022

Conversation

adpaco-aws
Copy link
Contributor

Description of changes:

Moves and updates or adds tests for exact_div, for which the UB conditions were not previously tested.

Note: The overflow_division.rs test is the one that required #981

Resolved issues:

Part of #727

Testing:

  • How is this change tested? Existing regression + updates for 1 test, adds 3 tests

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner April 1, 2022 21:58
zhassan-aws
zhassan-aws approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@adpaco-aws adpaco-aws merged commit b723860 into model-checking:main Apr 11, 2022
@adpaco-aws adpaco-aws mentioned this pull request Apr 11, 2022
Closed
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 22, 2022
@adpaco-aws @tedinski
More tests for exact_div (model-checking#1007)
cc90fa5
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 25, 2022
@adpaco-aws @tedinski
More tests for exact_div (model-checking#1007)
ffc69c3
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 26, 2022
@adpaco-aws @tedinski
More tests for exact_div (model-checking#1007)
76705fd
tedinski pushed a commit that referenced this pull request Apr 27, 2022
@adpaco-aws @tedinski
More tests for exact_div (#1007)
5299559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhassan-aws zhassan-aws zhassan-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adpaco-aws @zhassan-aws