Tests for "absolute" intrinsics #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsn
approved these changes
Apr 12, 2022
| kani::assume(!x.is_nan()); | ||
| let abs_x = unsafe { std::intrinsics::fabsf32(x) }; | ||
| if x < 0.0 { | ||
| assert!(-x == abs_x); |
There was a problem hiding this comment.
At first I was surprised that this was == and not diff < epsilon but I see that floating point has an explicit sign bit https://en.wikipedia.org/wiki/Floating-point_arithmetic#IEEE_754:_floating_point_in_modern_computers
Closed
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The implementation of "absolute" intrinsics (
fabsf32andfabsf64) relies on CBMC'sfabsfandfabs. This PR adds tests for them.Resolved issues:
Part of #727
Call-outs:
Testing:
How is this change tested? Adds two tests.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.