Add tests for trigonometric intrinsics #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhassan-aws
approved these changes
Apr 14, 2022
Closed
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
* Add test for `sinf32` * Add test for `sinf64` * Add test for `cosf32` * Add test for `cosf64` * Minor fix
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
* Add test for `sinf32` * Add test for `sinf64` * Add test for `cosf32` * Add test for `cosf64` * Minor fix
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Add test for `sinf32` * Add test for `sinf64` * Add test for `cosf32` * Add test for `cosf64` * Minor fix
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Add test for `sinf32` * Add test for `sinf64` * Add test for `cosf32` * Add test for `cosf64` * Minor fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds 4 tests for trigonometric functions
sinf32,sinf64,cosf32andcosf64.The models are over-approximations so other values cannot be tested for equality.
Resolved issues:
Part of #727
Testing:
How is this change tested? Adds 4 tests.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.