Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for ctpop #1048

Merged
merged 3 commits into from
Apr 15, 2022
Merged

Add a test for ctpop #1048

merged 3 commits into from
Apr 15, 2022

Conversation

adpaco-aws
Copy link
Contributor

@adpaco-aws adpaco-aws commented Apr 14, 2022

Description of changes:

Adds a test for ctpop that I had partially prepared but had some issues (#1046). It's also affected by #934.

Resolved issues:

Resolves #ISSUE-NUMBER

Call-outs:

The test for 128 takes a while, so I'd rather not include it (as indicated).
Affected by #934. Reproduces #1046 if the assertion is removed.

Testing:

  • How is this change tested? Existing regression.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner April 14, 2022 20:55
@adpaco-aws adpaco-aws merged commit 9d03f19 into model-checking:main Apr 15, 2022
@adpaco-aws adpaco-aws mentioned this pull request Apr 15, 2022
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 22, 2022
* Add a test for `ctpop`

* Fix format
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 25, 2022
* Add a test for `ctpop`

* Fix format
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 26, 2022
* Add a test for `ctpop`

* Fix format
tedinski pushed a commit that referenced this pull request Apr 27, 2022
* Add a test for `ctpop`

* Fix format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants