Audit for unchecked intrinsics #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhassan-aws
approved these changes
Apr 20, 2022
Closed
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
* Add positive test cases * Refactor `div_does_not_overflow` into fn, use in macro * Add negative test cases * Add negative tests for regular div/rem * Minor fixes for div/rem cases
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
* Add positive test cases * Refactor `div_does_not_overflow` into fn, use in macro * Add negative test cases * Add negative tests for regular div/rem * Minor fixes for div/rem cases
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Add positive test cases * Refactor `div_does_not_overflow` into fn, use in macro * Add negative test cases * Add negative tests for regular div/rem * Minor fixes for div/rem cases
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Add positive test cases * Refactor `div_does_not_overflow` into fn, use in macro * Add negative test cases * Add negative tests for regular div/rem * Minor fixes for div/rem cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Reviews and adds tests for all
unchecked_*operations.The most notable change is the addition of an overflow check for
unchecked_divandunchecked_rem, which were not failing in the case wherea == T::MIN && b == -1. This check was already written forexact_divso I refactored it into a function which is now used for unchecked div/rem.Then, I was afraid this was also the case for standard div/rem operations, but turns out this overflow check is already covered so no changes are needed. The tests I wrote to verify this are included as well.
Resolved issues:
Part of #727
Call-outs:
Testing:
How is this change tested? Adds many tests, in particular the ones to check an overflow that was previously not checked.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.