Fix issue with value_of / align_of traits #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were trying to figure out the values of those properties during runtime, which is not possible. Emit a runtime error for now.
danielsn
reviewed
Apr 21, 2022
| @@ -294,7 +294,17 @@ impl<'tcx> GotocCtx<'tcx> { | |||
| let tp_ty = instance.substs.type_at(0); | |||
| let arg = fargs.remove(0); | |||
| let size_align = self.size_and_align_of_dst(tp_ty, arg); | |||
| self.codegen_expr_to_place(p, size_align.$which) | |||
| if size_align.is_some() { | |||
There was a problem hiding this comment.
if let Some instead of using unwrap?
There was a problem hiding this comment.
Yes, because this can be None.
| // https://github.com/model-checking/kani/issues/1074 | ||
| // The size of dyn T is only known at runtime. Thus, we need to retrieve that | ||
| // information from the object vtable. | ||
| None |
There was a problem hiding this comment.
Does arg.member("vtable").member("size") not work here?
There was a problem hiding this comment.
Probably. I just didn't have time to go figure it out. Let me try and maybe we can just fix this issue. :)
| @@ -1004,7 +1013,7 @@ impl<'tcx> GotocCtx<'tcx> { | |||
| // Call this function recursively to compute the size and align for the last field. | |||
| let field_ty = layout.field(self, n).ty; | |||
| let SizeAlign { size: unsized_size, align: mut unsized_align } = | |||
| self.size_and_align_of_dst(field_ty, arg); | |||
| self.size_and_align_of_dst(field_ty, arg.clone())?; | |||
There was a problem hiding this comment.
Why is this clone now needed?
There was a problem hiding this comment.
This was probably some debug I removed and forgot to revert this. I'll remove it.
| fn check_align_simple() { | ||
| let a = A { id: 0 }; | ||
| let t: &dyn T = &a; | ||
| assert_eq!(align_of_val(t), 8); |
There was a problem hiding this comment.
Does this assume a particular architecture?
There was a problem hiding this comment.
This should hold for the architecture we currently support.
Use field in the vtable.
celinval
changed the title
adpaco-aws
approved these changes
Apr 21, 2022
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
We were trying to figure out the values of those properties during runtime, which is not possible. Fix the code to look for the information in the vtable instead.
4 tasks
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
We were trying to figure out the values of those properties during runtime, which is not possible. Fix the code to look for the information in the vtable instead.
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
We were trying to figure out the values of those properties during runtime, which is not possible. Fix the code to look for the information in the vtable instead.
Closed
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
We were trying to figure out the values of those properties during runtime, which is not possible. Fix the code to look for the information in the vtable instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We were trying to figure out the values of those properties during runtime, which is not possible. Fix the code to look for the information in the vtable instead.
Resolved issues:
Fixes #1074
Call-outs:
This is v2. The initial PR was trying to mitigate it but it turned out that the fix was straight forward.
Testing:
How is this change tested? New tests
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.