Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare unreachable intrinsic as unreachable #1119

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

adpaco-aws
Copy link
Contributor

Description of changes:

Includes the case for unreachable in the intrinsics match that is expected to be unreachable. This case was removed in #1100 (includes a test for unreachable), but as suggested by @zhassan-aws this way we avoid confusion.

Resolved issues:

Resolves #1115

Call-outs:

Testing:

  • How is this change tested? Existing regression.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner April 27, 2022 19:18
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adpaco-aws adpaco-aws merged commit fbd5264 into model-checking:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case for unreachable intrinsic is unreachable
2 participants