Move volatile_store and ensure alignment
#794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsn
reviewed
Feb 3, 2022
danielsn
reviewed
Feb 3, 2022
danielsn
reviewed
Feb 7, 2022
adpaco-aws
force-pushed
the
volatile-store
branch
from
a4910a6 to
0e7e428
Compare
zhassan-aws
reviewed
Feb 9, 2022
adpaco-aws
force-pushed
the
volatile-store
branch
from
0e7e428 to
8e87a06
Compare
adpaco-aws
force-pushed
the
volatile-store
branch
from
8e87a06 to
0939afb
Compare
Closed
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
* Move `volatile_store` and ensure alignment * Create util function for concurrency warnings * Add positive and negative test cases * Emit concurrency warning with macro
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
* Move `volatile_store` and ensure alignment * Create util function for concurrency warnings * Add positive and negative test cases * Emit concurrency warning with macro
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Move `volatile_store` and ensure alignment * Create util function for concurrency warnings * Add positive and negative test cases * Emit concurrency warning with macro
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Move `volatile_store` and ensure alignment * Create util function for concurrency warnings * Add positive and negative test cases * Emit concurrency warning with macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds an
is_alignedfunction to determine ifdstis aligned.Moves
volatile_storeout of thePtrWritehook. Now emits a warning during generation and adds a check for alignment.Resolved issues:
Part of #727
Call-outs:
Testing:
How is this change tested? Existing regression.
Is this a refactor change? Almost.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.