-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit: Atomic intrinsics #850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedinski
approved these changes
Feb 22, 2022
Closed
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
* Moved atomic intrinsics tests, added description * Add support for `atomic_nand*` * Support for `atomic_singlethreadfence` and variants * Add missing test for `atomic_cxchgweak` * Add negative tests for min & max atomics * Update doc with missing intrinsics
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
* Moved atomic intrinsics tests, added description * Add support for `atomic_nand*` * Support for `atomic_singlethreadfence` and variants * Add missing test for `atomic_cxchgweak` * Add negative tests for min & max atomics * Update doc with missing intrinsics
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Moved atomic intrinsics tests, added description * Add support for `atomic_nand*` * Support for `atomic_singlethreadfence` and variants * Add missing test for `atomic_cxchgweak` * Add negative tests for min & max atomics * Update doc with missing intrinsics
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Moved atomic intrinsics tests, added description * Add support for `atomic_nand*` * Support for `atomic_singlethreadfence` and variants * Add missing test for `atomic_cxchgweak` * Add negative tests for min & max atomics * Update doc with missing intrinsics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Intrinsics
folder.atomic_nand*
intrinsics.atomic_singlethreadfence*
intrinsics.atomic_cxchgweak*
intrinsics.atomic_min*
,atomic_umin*
,atomic_max*
andatomic_umax*
).Resolved issues:
Resolves #790
Part of #727
Call-outs:
Testing:
How is this change tested? Added and edited both positive and negative test cases to the standard regression.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.