Move and update saturating intrinsics #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedinski
approved these changes
Feb 22, 2022
adpaco-aws
force-pushed
the
saturating-ops-audit
branch
from
17f4b9d to
c645277
Compare
Closed
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
* Move and update saturating intrinsics * Add small test description
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
* Move and update saturating intrinsics * Add small test description
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Move and update saturating intrinsics * Add small test description
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Move and update saturating intrinsics * Add small test description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Moves
SaturatingIntrinsicstoIntrinsics/Saturating. Removes outdated standalone test for 128-bit values, and adds testing for 128-bit values to the main testing file.Resolved issues:
Part of #727
Creates #852
Call-outs:
Testing:
How is this change tested? Existing regression + more sophisticated testing for 128-bit values
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.