Negative test case for variant_count
#854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedinski
approved these changes
Feb 22, 2022
|
Should we check what kind of error is given to the user? |
The test is intentionally written this way to avoid error checking and to enable a smooth transition into a positive test. This is a good candidate for the newer testing suite we were discussing, and I want to move all these negative tests into that suite once it is available. But we can move it to |
|
Can you add the version without comments as a fixme test? |
adpaco-aws
force-pushed
the
variant-count-test
branch
from
f5e004a to
3258692
Compare
adpaco-aws
force-pushed
the
variant-count-test
branch
from
3258692 to
56ca888
Compare
|
@celinval just added the "fixme" test as requested and updated the negative one (removed commented out code to make it simpler). |
Closed
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
* Negative test case for `variant_count` * Add "fixme" test and update negative test Co-authored-by: Celina G. Val <celinval@amazon.com>
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
* Negative test case for `variant_count` * Add "fixme" test and update negative test Co-authored-by: Celina G. Val <celinval@amazon.com>
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Negative test case for `variant_count` * Add "fixme" test and update negative test Co-authored-by: Celina G. Val <celinval@amazon.com>
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Negative test case for `variant_count` * Add "fixme" test and update negative test Co-authored-by: Celina G. Val <celinval@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a negative test for the
variant_countintrinsic. Can easily converted into a positive one when support is added.Resolved issues:
Part of #727
Call-outs:
Testing:
How is this change tested? Adding another test.
Is this a refactor change? N/A
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.