Thorough testing for rotate intrinsics #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhassan-aws
approved these changes
Mar 2, 2022
Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
Closed
This was referenced Mar 14, 2022
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
* Add thorough tests for rotate intrinsics * Remove concrete tests for rotate intrinsics * Move code after test description * format * Update comment Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com> Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
* Add thorough tests for rotate intrinsics * Remove concrete tests for rotate intrinsics * Move code after test description * format * Update comment Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com> Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Add thorough tests for rotate intrinsics * Remove concrete tests for rotate intrinsics * Move code after test description * format * Update comment Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com> Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Add thorough tests for rotate intrinsics * Remove concrete tests for rotate intrinsics * Move code after test description * format * Update comment Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com> Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a couple of complete tests for rotate intrinsics. Removes testing related to these intrinsics anywhere else.
Resolved issues:
Part of #727
Testing:
How is this change tested? Existing (edited) regression + 2 new tests.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.