Complete tests for count intrinsics #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
approved these changes
Mar 3, 2022
| use std::intrinsics::cttz_nonzero; | ||
|
|
||
| // Call `cttz_nonzero` with an unconstrained symbolic argument | ||
| macro_rules! test_cttz_nonzero { |
There was a problem hiding this comment.
Why is this named nonzero?
There was a problem hiding this comment.
Because it is testing the cttz_nonzero intrinsic.
| @@ -0,0 +1,25 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| // SPDX-License-Identifier: Apache-2.0 OR MIT | |||
| // kani-verify-fail | |||
There was a problem hiding this comment.
Won't this test pass if just one property fail?
There was a problem hiding this comment.
Yes, however they are all encoded the same way so it is very likely that if one stops failing (for any reason) the rest will stop failing too.
zhassan-aws
reviewed
Mar 3, 2022
tests/kani/Intrinsics/Count/ctlz.rs
Outdated
| // exclude zero | ||
| macro_rules! test_ctlz_nonzero { | ||
| ($ty:ty) => { | ||
| let var_nonzero: $ty = 8; |
There was a problem hiding this comment.
Was this intended to be assigned to kani::any() instead of 8?
There was a problem hiding this comment.
Yes, thanks for catching it! Fixed 😄
This was referenced Mar 14, 2022
Closed
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
* Complete tests for count intrinsics * Use `kani::any()` instead of concrete value in `test_ctlz_nonzero`
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
* Complete tests for count intrinsics * Use `kani::any()` instead of concrete value in `test_ctlz_nonzero`
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Complete tests for count intrinsics * Use `kani::any()` instead of concrete value in `test_ctlz_nonzero`
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Complete tests for count intrinsics * Use `kani::any()` instead of concrete value in `test_ctlz_nonzero`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds more complete tests for count intrinsics. Removes the old tests that were based on concrete values.
Resolved issues:
Resolves #26
Part of #727
Call-outs:
Testing:
How is this change tested? Existing regression + changes to tests.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.