Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getPatternLength typo & fixed allocate memory for array issue #62

Merged
merged 2 commits into from
May 12, 2022

Conversation

lbutler
Copy link
Contributor

@lbutler lbutler commented May 12, 2022

No description provided.

Any method passing in an array of values was failing, corrected memory allocation and transfer and added tests for vertexes and patterns
@codecov-commenter
Copy link

Codecov Report

Merging #62 (47e46ca) into master (0dcc25a) will increase coverage by 4.36%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   75.03%   79.40%   +4.36%     
==========================================
  Files          17       17              
  Lines         705      704       -1     
  Branches       14       14              
==========================================
+ Hits          529      559      +30     
+ Misses        163      133      -30     
+ Partials       13       12       -1     
Impacted Files Coverage Δ
packages/epanet-js/src/Project/Project.ts 96.98% <100.00%> (+3.57%) ⬆️
...ges/epanet-js/src/Project/functions/TimePattern.ts 74.28% <100.00%> (+37.14%) ⬆️
...ges/epanet-js/src/Project/functions/NetworkLink.ts 80.88% <0.00%> (+17.64%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lbutler lbutler merged commit be97533 into master May 12, 2022
@lbutler lbutler deleted the vertex-fix branch May 12, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants