From 08a9fa3bb8718de560b0b00e1c0b191af639fa36 Mon Sep 17 00:00:00 2001 From: Henrik Klarup Date: Wed, 9 Dec 2020 13:59:21 +0100 Subject: [PATCH 1/3] fix(test-runner-visual-regression): Save current image into 'failing' image, instead of diff image" --- packages/test-runner-visual-regression/src/pixelMatchDiff.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/test-runner-visual-regression/src/pixelMatchDiff.ts b/packages/test-runner-visual-regression/src/pixelMatchDiff.ts index 36b2f3081..188cfabed 100644 --- a/packages/test-runner-visual-regression/src/pixelMatchDiff.ts +++ b/packages/test-runner-visual-regression/src/pixelMatchDiff.ts @@ -25,7 +25,7 @@ export function pixelMatchDiff({ baselineImage, image, options }: DiffArgs): Dif const diffPercentage = (numDiffPixels / (width * height)) * 100; return { - diffImage: diff.data, + diffImage: PNG.sync.write(diff), diffPercentage, }; } From 94e24e3ef20295401bc54d4c4bcc2d014babdff6 Mon Sep 17 00:00:00 2001 From: Henrik Klarup Date: Wed, 9 Dec 2020 13:59:42 +0100 Subject: [PATCH 2/3] fix(test-runner-visual-regression): Write diffimage using PNG.sync --- packages/test-runner-visual-regression/src/visualDiffCommand.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/test-runner-visual-regression/src/visualDiffCommand.ts b/packages/test-runner-visual-regression/src/visualDiffCommand.ts index 20acb2bc3..d524db655 100644 --- a/packages/test-runner-visual-regression/src/visualDiffCommand.ts +++ b/packages/test-runner-visual-regression/src/visualDiffCommand.ts @@ -64,7 +64,7 @@ export async function visualDiffCommand( filePath: resolveImagePath(baseDir, failedName), baseDir, name: failedName, - content: diffImage, + content: image, }); } From bbe94a2b39568b004235120ce7157bd4313e32ce Mon Sep 17 00:00:00 2001 From: Henrik Klarup Date: Wed, 9 Dec 2020 14:11:30 +0100 Subject: [PATCH 3/3] chore: Added changeset --- .changeset/strong-mayflies-cheat.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/strong-mayflies-cheat.md diff --git a/.changeset/strong-mayflies-cheat.md b/.changeset/strong-mayflies-cheat.md new file mode 100644 index 000000000..d190ad674 --- /dev/null +++ b/.changeset/strong-mayflies-cheat.md @@ -0,0 +1,5 @@ +--- +'@web/test-runner-visual-regression': patch +--- + +Fixing bugs related to writing failed and diff images