Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unwanted files showing in a modpack (macos) #1002

Closed
Ken-Miles opened this issue Jan 18, 2024 · 1 comment · Fixed by #1304
Closed

unwanted files showing in a modpack (macos) #1002

Ken-Miles opened this issue Jan 18, 2024 · 1 comment · Fixed by #1304
Labels
bug Something isn't working

Comments

@Ken-Miles
Copy link

Describe the bug

So when using modrinth, I have modpacks with mods and resource packs and the like.

However, some unwanted files are showing that obviously shouldn't by default. That is the .DS_Store file on Mac devices.

There may be other files like that, but that's the only one I noticed.

Steps to reproduce

Enter/Create a modpack ON MAC

On the very first page, usually the forbidden .DS_Store file will be the first in the list alphabetically.

Expected behavior

.DS_Store should not show in the modpack.

System information

MacOS Montery (12.3)

Additional context

Sometimes when you disable/delete the file it will go away, but it will usually come back after a while.
@Ken-Miles Ken-Miles added the bug Something isn't working label Jan 18, 2024
@Ken-Miles
Copy link
Author

I disabled and deleted the file, but after about 15 minutes and a restart of Modrinth it is back again.
Screen Shot 2024-01-18 at 10 10 00

@w26ad w26ad mentioned this issue Jan 23, 2024
Closed
Norbiros added a commit to Norbiros/code that referenced this issue Jul 18, 2024
@Norbiros
fix(theseus): Hide .DS_Store files (modrinth#1274, modrinth#1002, m…
b661f21 
…odrinth#1174)
@Norbiros Norbiros mentioned this issue Jul 18, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 20, 2024
@Norbiros
fix(theseus): Fixed multiple bugs (#1304)
797e1f1 
* fix(theseus): Resolve log tab freezing entire app (#1127, #1237)
Switched to `vue-typed-virtual-list` due to freezing issues in WebKit caused by `vue-virtual-scroller`, which were difficult to resolve with the previous library.

* fix(theseus): Double opening of Socials Share link (#1136, #1074)

* fix(theseus): Proper symlinks resolution (#1236)
Ensures correct symlink resolution for specific mods, the mods directory, and the entire profile directory.

* fix(theseus): Correctly recognize NeoForge mods (#1215)

* fix(theseus): Corrected `Environments` and `Loaders` filters (#899)

* fix(theseus): Remove `_JAVA_OPTIONS` when testing JRE (#1171)

* fix(theseus): Fixed opening files using `show_in_folder`
Previously, opening a mod would display the contents of the JAR file instead of its location.

* fix(theseus): Hide `.DS_Store` files (#1274, #1002, #1174)

* fix(theseus): Corrected tooltip color

* fix(theseus): Fixed white mode issues (#1144, #1010)

* fix: Corrected `Slider` min and max value handling (#1008)

* fix: Fixed rebase problems

* fix: Fixed `:deep` usage warning

* chore: Updated eslint plugins to fix conflicts with Prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(theseus): Fixed multiple bugs Norbiros/code
1 participant
@Ken-Miles